fix render bugs in xray and wallhack modules when using Indigo renderer (FAPI)#6393
Merged
Merged
Conversation
affected modules: xray and wallhack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bug fix
New feature
Description
when using Indigo renderer from fabric api (fapi) transparency was not working on both modules because
AltModelBlockRendererImplMixin.transform$xray()never changes the chunk layer toTRANSLUCENTwhen alpha is not 0 and 255fix its just add call inside the
else iftochecking when
alpha > 0 && alpha < 255and import of course
also there was a bug in xray where only ores hidden faces were rendering (opposite behavior)
this is because
ModelBlockRenderer.shouldRenderFacereturnstrueto show exposed facesAltModelBlockRendererImpl.shouldCullFacereturnstrueto hide exposed facesas you can see logic is reversed
the fix is just invert
originalsomodifyDrawSidereturnstrueand then invert again that return so it converts tofalsepreventingshouldCullFaceworking while xray is activeRelated issues
#6389
How Has This Been Tested?
singleplayer and multiplayer
turning on xray and later wallhack
opacity set to different values, works fine
Checklist:
My code follows the style guidelines of this project.
I have added comments to my code in more complex areas. (no needed)
I have tested the code in both development and production environments.