Repository navigation
Forward serdevalid collection bounds through Nullable - #202
Open
EricLiu2000 wants to merge 1 commit into
Open
EricLiu2000 wants to merge 1 commit into
EricLiu2000 wants to merge 1 commit into
Conversation
EricLiu2000
force-pushed
the
codex/validate-nullable-collection-size
branch
from
October 15, 2026 03:59
0a497f0 to
0b299fd
Compare
Signed-off-by: Eric Liu <ericxliu@gmail.com>
EricLiu2000
force-pushed
the
codex/validate-nullable-collection-size
branch
from
October 15, 2026 04:19
0b299fd to
bfcc824
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201.
Forward
ValidateMinItemsandValidateMaxItemsthroughNullable<T>.Nullpasses these bounds;Present(value)returns the inner value's validation result. This also supportsOption<Nullable<T>>through serde_valid's existingOptionimplementation.Validation:
cargo fmt -- --check,cargo test,cargo test --all-features,cargo clippy --all-targets -- -D warnings, andcargo clippy --all-targets --all-features -- -D warningspass. The new test fails to compile before the fix and covers null, absent, valid, and out-of-bound values.