fix: default analytics cookies checkbox to unchecked#4941
Conversation
Closes #2171 Co-authored-by: aseckin <aseckin@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe cookies banner now starts with analytics unchecked and records consent through an explicit boolean path. Button actions and modal submission were updated to pass the consent choice directly before persisting it and refreshing the page. ChangesCookies banner consent flow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@claude implement the follow-up change so clicking "Accept All" properly accepts all, without the need to check the analytics box |
|
Claude finished @aseckin's task in 1m 35s —— View job Implementing follow-up: "Accept and close" should accept all cookies
SummaryRefactored
This decouples the banner's "Accept and close" path from the modal's checkbox state, so the unchecked default from this PR no longer leaks into the accept-all flow. Commit: |
Refactors submitBanner to take an explicit analyticsConsent boolean so each call site decides intent: "Necessary only" → false, "Accept and close" → true, modal "Save selected" → checkbox value. Previously, with the analytics checkbox defaulting to unchecked, "Accept and close" would silently deny analytics consent. Co-authored-by: aseckin <aseckin@users.noreply.github.com>
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
Closes #2171
Summary
Changes the default state of the "Analytics cookies" checkbox in the cookie consent customize modal from checked to unchecked.
Note
This also affects the "Accept and close" button: since it reads from the same state, clicking it without customizing will no longer grant analytics consent. If "Accept and close" should still accept all cookies, a follow-up change to
submitBanneris needed.Generated with Claude Code
Summary by CodeRabbit