Skip to content

Minor source-archive cleanup #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
probably-jaden merged 1 commit into from
Jun 25, 2026
Merged

Minor source-archive cleanup #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions code_tests/unit_tests/test_agents_and_tools/test_source_archive/test_trace_extraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def test_harvest_run_walks_bot_and_question_dirs(tmp_path: Path):


def test_harvest_run_flat_layout_without_bot_dirs(tmp_path: Path):
# Butler-style: <run>/<question>/traces_*.jsonl with no bot_* grouping.
# Flat layout: <run>/<question>/traces_*.jsonl with no bot_* grouping.
run = tmp_path / "s3_backfill"
qdir = run / "2026-05-20_metac_43538"
qdir.mkdir(parents=True)
Expand All @@ -196,10 +196,10 @@ def test_harvest_run_flat_layout_without_bot_dirs(tmp_path: Path):
qdir / "traces_forecast_1.jsonl",
[{"type": "tool_result", "content": "https://a.test/x"}],
)
records = harvest_run(str(run), bot="butler")
records = harvest_run(str(run), bot="mybot")
assert len(records) == 1
rec = records[0]
assert rec.bot == "butler" # the flat-layout bot override
assert rec.bot == "mybot" # the flat-layout bot override
assert rec.metaculus_id == "43538" # still read from question.json


Expand Down
2 changes: 1 addition & 1 deletion forecasting_tools/agents_and_tools/source_archive/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ each captured URL's **screenshot, markdown, and HTML** side by side, filterable
by bot and question:

```bash
AWS_PROFILE=default WEB_ARCHIVE_S3_BUCKET=metaculus-web-archive \
AWS_PROFILE=default WEB_ARCHIVE_S3_BUCKET=my-web-archive \
streamlit run forecasting_tools/agents_and_tools/source_archive/viewer.py
```

Expand Down
2 changes: 1 addition & 1 deletion forecasting_tools/agents_and_tools/source_archive/reindex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
Run it::

# against the configured S3 bucket (read-only audit)
WEB_ARCHIVE_S3_BUCKET=metaculus-web-archive WEB_ARCHIVE_AWS_PROFILE=default \\
WEB_ARCHIVE_S3_BUCKET=my-web-archive WEB_ARCHIVE_AWS_PROFILE=default \\
python -m forecasting_tools.agents_and_tools.source_archive.reindex

# against a local capture dir
Expand Down
2 changes: 1 addition & 1 deletion forecasting_tools/agents_and_tools/source_archive/viewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
Run it::

# uses the same env as the rest of the archive (WEB_ARCHIVE_S3_BUCKET, etc.)
AWS_PROFILE=default WEB_ARCHIVE_S3_BUCKET=metaculus-web-archive \\
AWS_PROFILE=default WEB_ARCHIVE_S3_BUCKET=my-web-archive \\
streamlit run forecasting_tools/agents_and_tools/source_archive/viewer.py

Nothing here is deployment-specific: bucket/prefix/profile come from
Expand Down
Loading