Skip to content

feat(solana-wallet-snap): use shareable serialization in Solana snap - #230

Open
Julink-eth wants to merge 6 commits into
mainfrom
feat/WPN-1943-use-shared-serialization-in-solana-snap
Open

feat(solana-wallet-snap): use shareable serialization in Solana snap#230
Julink-eth wants to merge 6 commits into
mainfrom
feat/WPN-1943-use-shared-serialization-in-solana-snap

Conversation

@Julink-eth

Copy link
Copy Markdown
Contributor

Explanation

  • Switch the Solana snap from local serialize / deserialize / Serializable to the shared helpers in @metamask/snap-networks-utils (WPN-1943).
  • Delete packages/solana-wallet-snap/src/core/serialization/ and rewire every call site (state, interface context, cache, clients, confirmation UI) to the shared package.
  • Cast serialize() results to Record<string, Json> at the three snap-API call sites that require an object (snap_createInterface, snap_updateInterface, snap_manageState). The shared helper is typed as Json; those values are always objects.
  • Drop unused eslint-suppressions.json entries that pointed at the deleted local serialization files.
  • No changelog entry: this is an internal rewire with no consumer-facing API change.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Julink-eth
Julink-eth requested review from a team as code owners August 28, 2026 10:01
@Julink-eth
Julink-eth deployed to default-branch August 28, 2026 10:02 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant