-
Notifications
You must be signed in to change notification settings - Fork 1
bump: snap-sdk to 12.0.1 + snap-utils to 12.6.0 + keyring-api to 24.1.0 + snaps-execution-environments to 11.3.0 + metamask/snaps-jest to 10.2.1 + metamask/keyring-snap-sdk to 10.0.0
#214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2580da2
2f88e92
9eb1740
5097eaf
5402d9b
b36fa8f
44c9de6
f70542e
fa54740
060d142
9273c63
7e5dd77
ac06bc2
8af3d98
07fb687
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,8 +83,9 @@ | |
| "yargs": "^17.7.2" | ||
| }, | ||
| "resolutions": { | ||
| "@metamask/snaps-execution-environments": "11.2.0", | ||
| "@metamask/snaps-sdk": "11.2.0", | ||
| "@metamask/snaps-execution-environments": "11.3.0", | ||
| "@metamask/snaps-sdk": "12.0.1", | ||
| "@metamask/snaps-utils": "12.6.0", | ||
|
Comment on lines
+87
to
+88
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
stanleyyconsensys marked this conversation as resolved.
|
||
| "@solana/addresses": "2.1.0", | ||
|
stanleyyconsensys marked this conversation as resolved.
stanleyyconsensys marked this conversation as resolved.
|
||
| "@solana/kit": "2.1.0", | ||
| "@stellar/stellar-sdk/axios@npm:1.15.0": "1.18.1", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,6 @@ | |
| "snaps": false | ||
| } | ||
| }, | ||
| "platformVersion": "11.1.1", | ||
| "platformVersion": "12.0.1", | ||
| "manifestVersion": "0.1" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| "url": "https://github.com/MetaMask/internal-snaps.git" | ||
| }, | ||
| "source": { | ||
| "shasum": "5FfpznC3zSm/PzcS3bNGu1a/heN2o1uLIfoc/y3xpMc=", | ||
| "shasum": "/bPlQ2LMoy4F7lHNq/tgFAZQmxNGT8gNvJhM8f6TYyo=", | ||
| "location": { | ||
| "npm": { | ||
| "filePath": "dist/bundle.js", | ||
|
|
@@ -90,6 +90,6 @@ | |
| "snap_dialog": {}, | ||
| "snap_getPreferences": {} | ||
| }, | ||
| "platformVersion": "11.2.0", | ||
| "platformVersion": "12.0.1", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. when we build the snap,
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updating this will now pass
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. verified Safe for all snap |
||
| "manifestVersion": "0.1" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,12 +50,12 @@ | |
| "devDependencies": { | ||
| "@metamask/auto-changelog": "^6.1.1", | ||
| "@metamask/key-tree": "^10.1.1", | ||
| "@metamask/keyring-api": "^23.7.0", | ||
| "@metamask/keyring-snap-sdk": "^9.2.1", | ||
| "@metamask/keyring-api": "^24.1.0", | ||
| "@metamask/keyring-snap-sdk": "^10.0.0", | ||
| "@metamask/snap-networks-utils": "^1.0.0", | ||
| "@metamask/snaps-cli": "^8.4.1", | ||
| "@metamask/snaps-jest": "^10.2.0", | ||
| "@metamask/snaps-sdk": "^11.2.0", | ||
| "@metamask/snaps-jest": "^10.2.1", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. update metamask/snaps-jest to 10.2.1 is to align the snap sdk |
||
| "@metamask/snaps-sdk": "^12.0.1", | ||
| "@metamask/superstruct": "^3.4.1", | ||
| "@metamask/utils": "^11.11.0", | ||
| "@stellar/stellar-sdk": "^15.0.1", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a resolution needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, i think we dont need to resolve the metamask/snaps-sdk
for metamask/snaps-execution-environments may still need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you would need it for any of the packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh actually it need
snap cli 8.4.1 is using metamask/snaps-sdk 10.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I would bump the CLI eventually, but you can do a resolution for now I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snaps-execution-environments is becoz
asset controller -> account tree controlller -> snaps-execution-environments