feat(stellar-wallet-snap): use shareable permissions helpers in Stellar snap - #212
Open
Julink-eth wants to merge 1 commit into
Open
feat(stellar-wallet-snap): use shareable permissions helpers in Stellar snap#212Julink-eth wants to merge 1 commit into
Julink-eth wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the Stellar snap’s local origin-permission map wiring and
validateOriginwith the shared helpers from@metamask/snap-networks-utils.permissions.tsstill owns the method lists. The map is built withcreateOriginPermissions: Portfolio is registered with an empty dapp method set (every dapp call is rejected), and the MetaMask origin keeps the existing keyring methods. Stellar has no local/test origin toggle, and this PR does not add one.KeyringHandlercallsvalidateOrigin(origin, method, originPermissions)from the shared package. The local wrapper inrequestResponse.tsis removed.validateOriginon@metamask/snap-networks-utils.Permission surface is unchanged.
References
Checklist