Skip to content

gabrieledm/tests/tron/remove beforeEach usage in useCache falsy but valid cache values - #210

Closed
gabrieledm wants to merge 7 commits into
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_function-name-overridefrom
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values
Closed

gabrieledm/tests/tron/remove beforeEach usage in useCache falsy but valid cache values#210
gabrieledm wants to merge 7 commits into
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_function-name-overridefrom
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values

Conversation

@gabrieledm

@gabrieledm gabrieledm commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Explanation

Last PR for refactor of tests under packages/tron-wallet-snap/src/caching/useCache.test.ts to remove the usage of beforeEach and follow the Unit Testing Guidelines

To split the PRs is used the Stacked pull requests feature from GitHub

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values branch from df248db to 620e686 Compare August 26, 2026 14:47
@gabrieledm
gabrieledm marked this pull request as ready for review August 26, 2026 14:55
@gabrieledm
gabrieledm requested review from a team as code owners August 26, 2026 14:55
@gabrieledm
gabrieledm deployed to default-branch August 26, 2026 14:55 — with GitHub Actions Active
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values branch from d25dbaf to 951dcbd Compare August 26, 2026 15:03
@gabrieledm
gabrieledm dismissed ulissesferreira’s stale review August 27, 2026 14:06

The merge-base changed after approval.

@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values branch 3 times, most recently from d29b7a7 to 8abf111 Compare August 27, 2026 14:22
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values branch from 8abf111 to 7d1ff68 Compare August 27, 2026 14:36
@gabrieledm
gabrieledm deployed to default-branch August 27, 2026 14:55 — with GitHub Actions Active
@gabrieledm

Copy link
Copy Markdown
Contributor Author

Replaced by #223

@gabrieledm gabrieledm closed this Aug 27, 2026
@gabrieledm
gabrieledm deleted the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_falsy-but-valid-cache-values branch August 27, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants