Skip to content

gabrieledm/tests/tron/remove beforeEach usage in useCache custom generateCacheKey #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrieledm wants to merge 1 commit into from
Closed

gabrieledm/tests/tron/remove beforeEach usage in useCache custom generateCacheKey #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions packages/tron-wallet-snap/src/caching/useCache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,16 @@ import type { ICache } from './ICache';
import { useCache } from './useCache';
import type { CacheOptions } from './useCache';

// Define common cache options
const cacheOptions = {
ttlMilliseconds: 1000,
functionName: 'testFunction',
};

type WithUseCacheCallback = (payload: {
actualExecutionSpy: jest.Mock<Promise<string>, Serializable[]>;
cache: ICache<Serializable>;
testFunction: () => Promise<string>;
cachedTestFunction: () => Promise<string>;
cachedTestFunctionWithArgs: (arg1: string, arg2: number) => Promise<string>;
cachedTestFunctionWithComplexArgs: (obj: {
Expand All @@ -22,7 +29,6 @@ type WithUseCacheCallback = (payload: {
* @param testFn - The test body receiving the cached functions.
* @returns A promise that resolves when the test function completes.
*/

async function withUseCache(testFn: WithUseCacheCallback): Promise<void> {
// Reset mocks for each test
const actualExecutionSpy = jest
Expand All @@ -35,12 +41,6 @@ async function withUseCache(testFn: WithUseCacheCallback): Promise<void> {
set: jest.fn().mockResolvedValue(undefined),
} as unknown as ICache<Serializable>;

// Define common cache options
const cacheOptions = {
ttlMilliseconds: 1000,
functionName: 'testFunction',
};

// Define original functions
const testFunction = async (): Promise<string> => actualExecutionSpy();
const testFunctionWithArgs = async (
Expand Down Expand Up @@ -75,6 +75,7 @@ async function withUseCache(testFn: WithUseCacheCallback): Promise<void> {
await testFn({
actualExecutionSpy,
cache,
testFunction,
cachedTestFunction,
cachedTestFunctionWithArgs,
cachedTestFunctionWithComplexArgs,
Expand Down Expand Up @@ -280,17 +281,19 @@ describe('useCache', () => {

describe('custom generateCacheKey', () => {
it('should use a custom key generator if provided', async () => {
const customKeyGenerator = jest.fn().mockReturnValue('custom-key');
await withUseCache(async ({ cache, testFunction }) => {
const customKeyGenerator = jest.fn().mockReturnValue('custom-key');

const customCachedFunction = useCache(testFunction, cache, {
...cacheOptions,
generateCacheKey: customKeyGenerator,
});
const customCachedFunction = useCache(testFunction, cache, {
...cacheOptions,
generateCacheKey: customKeyGenerator,
});

await customCachedFunction();
await customCachedFunction();

expect(customKeyGenerator).toHaveBeenCalledTimes(1);
expect(cache.get).toHaveBeenCalledWith('custom-key');
expect(customKeyGenerator).toHaveBeenCalledTimes(1);
expect(cache.get).toHaveBeenCalledWith('custom-key');
});
});
});

Expand Down