Skip to content

gabrieledm/tests/tron/remove beforeEach usage in useCache different argument types - #205

Closed
gabrieledm wants to merge 3 commits into
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_error-handlingfrom
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types
Closed

gabrieledm/tests/tron/remove beforeEach usage in useCache different argument types#205
gabrieledm wants to merge 3 commits into
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_error-handlingfrom
gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types

Conversation

@gabrieledm

@gabrieledm gabrieledm commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Explanation

Fifth PR for refactor of tests under packages/tron-wallet-snap/src/caching/useCache.test.ts to remove the usage of beforeEach and follow the Unit Testing Guidelines

To split the PRs is used the Stacked pull requests feature from GitHub

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types branch from d035342 to 4522ac9 Compare August 26, 2026 14:47
@gabrieledm
gabrieledm marked this pull request as ready for review August 26, 2026 14:59
@gabrieledm
gabrieledm requested a review from a team as a code owner August 26, 2026 14:59
@gabrieledm
gabrieledm deployed to default-branch August 26, 2026 14:59 — with GitHub Actions Active
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types branch from 4522ac9 to ebec211 Compare August 26, 2026 15:00
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types branch from ebec211 to b24c625 Compare August 26, 2026 15:03
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types branch from b24c625 to 407cea5 Compare August 27, 2026 14:04
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types branch from 407cea5 to 0cf7ea1 Compare August 27, 2026 14:06
@gabrieledm
gabrieledm force-pushed the gabrieledm/tests/tron/remove-beforeEach-usage-in-useCache_different-argument-types branch from 04e6823 to 99a7bc0 Compare August 27, 2026 14:29
@gabrieledm

Copy link
Copy Markdown
Contributor Author

Replaced by #223

@gabrieledm gabrieledm closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants