test: tag @metamask-qa-team in feature flag drift Slack noti - #289
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
LeVinhGithub
marked this pull request as ready for review
September 9, 2026 02:49
vivek-consensys
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the reusable feature-flag-drift-slack-noti action so drift Slack messages mention @metamask-qa-team, pinging the whole QA user group instead of posting a silent channel message that is easy to miss.
Changes
slack-subteam: New optional input (defaultS0832MYT8QZ/@metamask-qa-team). Pass empty to skip the mention.<!subteam^ID>so incoming webhooks actually notify the user group.textfallback so Slack push notifications still fire.link_names: trueas extra insurance for mention parsing.Testing
@metamask-qa-teamappears at the end of the message (not in the title).@metamask-qa-teamreceive a Slack ping/notification.slack-subteam: ''and confirm the mention is omitted.Fixes
Fixes: N/A
Note
Low Risk
Changes only affect GitHub Action Slack notification formatting and optional QA group mentions, with no impact on application runtime or security-sensitive paths.
Overview
Feature flag drift Slack notifications now ping @metamask-qa-team by default so drift alerts are harder to miss in channel-only posts.
The feature-flag-drift-slack-noti composite action adds an optional
slack-subteaminput (default user groupS0832MYT8QZ; pass empty to skip). The payload builder constructs a<!subteam^ID>mention for incoming webhooks, keeps the headline unchanged, appends the mention as the last Block Kit section, duplicates it in top-leveltextfor push notifications, and setslink_names: true. Both PR and non-PR payload paths use the same mention logic.Reviewed by Cursor Bugbot for commit 4f5d65d. Bugbot is set up for automated code reviews on this repo. Configure here.