Skip to content

feat: support trending feed scope #10895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xavier-brochard merged 2 commits into from
Oct 20, 2026
Merged

feat: support trending feed scope #10895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd5d48
feat: support trending feed scope
xavier-brochard Oct 19, 2026
7db64f7
chore: document trending feed scope
xavier-brochard Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/social-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Add optional `createdAt` to `TraderProfile`. `fetchTraderProfile` accepts an ISO-8601 timestamp, or `null`, on `GET /traders/:addressOrId/profile` and still accepts responses that omit it ([#10877](https://github.com/MetaMask/core/pull/10877))
- Add the shared `all` feed scope to `FetchFeedOptions` and export `FeedScope`. Preserve optional `eventId`, `revision`, and `occurredAt` projection metadata on `FeedItem` ([#10865](https://github.com/MetaMask/core/pull/10865))
- Add the `trending` feed scope to `FetchFeedOptions` and export `FeedScope` for policy-filtered trending feed reads ([#10895](https://github.com/MetaMask/core/pull/10895))

### Changed

Expand Down
3 changes: 2 additions & 1 deletion packages/social-controllers/src/SocialService-method-action-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ export type SocialServiceFetchPositionByIdAction = {
* `pagination.newerCursor` as `newerThan` to fetch newer items.
*
* @param options - Options bag.
* @param options.scope - `following` (default) or `leaderboard`.
* @param options.scope - `following` (default), `leaderboard`, `all`, or
* `trending`.
* @param options.chains - Filter by one or more chains.
* @param options.limit - Number of results per page.
* @param options.olderThan - Cursor for older items (scroll down).
Expand Down
3 changes: 2 additions & 1 deletion packages/social-controllers/src/SocialService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,8 @@ export class SocialService extends BaseDataService<
* `pagination.newerCursor` as `newerThan` to fetch newer items.
*
* @param options - Options bag.
* @param options.scope - `following` (default) or `leaderboard`.
* @param options.scope - `following` (default), `leaderboard`, `all`, or
* `trending`.
* @param options.chains - Filter by one or more chains.
* @param options.limit - Number of results per page.
* @param options.olderThan - Cursor for older items (scroll down).
Expand Down
2 changes: 1 addition & 1 deletion packages/social-controllers/src/social-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ export type FetchFeedOptions = {
newerThan?: string;
};

export type FeedScope = 'following' | 'leaderboard' | 'all';
export type FeedScope = 'following' | 'leaderboard' | 'all' | 'trending';

export type FetchPositionByIdOptions = {
/** Unique position ID (UUID). */
Expand Down
Loading