chore: align Dependabot npm cooldown with the Yarn minimal age gate - #10226
Closed
cryptodev-2s wants to merge 1 commit into
Closed
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
marked this pull request as draft
September 14, 2026 12:52
cryptodev-2s
deleted the
chore/align-dependabot-cooldown-with-yarn-age-gate
branch
September 14, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
.yarnrc.ymlsetsnpmMinimalAgeGate: 4320, so Yarn refuses to install any package published less than 3 days ago, andnpmPreapprovedPackagesexempts@metamask/*,@metamask-previews/*and@lavamoat/*from that gate. Dependabot'scooldownexists to stop it proposing a version the gate would reject, but the npm block applieddefault-days: 3to everything with no exclusions, so the two configs did not actually line up.In practice it was backwards. The npm block only allows
@metamask/*, and those are exactly the packages Yarn pre-approves, so the cooldown was delaying the one group that needs no delay by three days and delaying nothing else, because nothing else is allowed through. This adds anexcludelist matchingnpmPreapprovedPackagesso the two files say the same thing.Today that is mostly a latency win on MetaMask package bumps. It matters more under WPC-1161, where we drop the
@metamask/*allowlist so Dependabot bumps third party packages too. Those are the ones Yarn actually gates, anddefault-days: 3is what keeps Dependabot from opening a pull request that cannot install.I left the
github-actionsblock alone. Its cooldown is a separate policy call and has nothing to do with the Yarn npm gate.One gap this does not close
Per the options reference, "the
cooldownoption is only available for version updates, not security updates". So a Dependabot security update can still propose a version younger than 3 days, andyarn installwill reject it for a reason unrelated to the bump itself. Nothing independabot.ymlcan prevent that. Worth knowing before we widen the allowlist, since security updates are already the path that produces our most awkward pull requests.Verification
Config only, so no behaviour to run. I checked the YAML parses and that both files agree:
References
Part of WPC-1161, following #10225.
Checklist
Note
Low Risk
YAML-only Dependabot configuration with no application or CI logic changes.
Overview
Aligns Dependabot’s npm
cooldownwith Yarn’s 3-daynpmMinimalAgeGateso version-update PRs are not proposed for packages Yarn would refuse to install.Adds
cooldown.excludefor@metamask/*,@metamask-previews/*, and@lavamoat/*, matchingnpmPreapprovedPackagesin.yarnrc.yml, plus inline comments explaining the mirror. MetaMask-family bumps can proceed without an extra 3-day Dependabot delay; third-party bumps (when the allowlist widens) still respectdefault-days: 3. The github-actions Dependabot block is unchanged.Reviewed by Cursor Bugbot for commit 12d07b1. Bugbot is set up for automated code reviews on this repo. Configure here.