fix(activity): map musdConversion as send not convert - #10217
Draft
n3ps wants to merge 2 commits into
Draft
Conversation
Stop inventing convert activity rows with source/destination token pairs for mUSD conversion orchestration txs. Classify them as ordinary ERC-20 sends and defer accurate activity data to the indexed API. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionType.musdConversionthrough the existing ERC-20 transfer (send) path inlocal-transaction-mapperconvertcase that parsed calldata and inventedsourceToken/destinationTokenpairsCompanion to MetaMask/metamask-extension#46254, which removes convert UI treatment and excludes
musdConversionfrom local activity until the indexed API is authoritative.Test plan
yarn test:verbose --testPathPatterns=local-transaction-mapper.test.ts --coverage=falseinpackages/client-utils(80 passed)Made with Cursor