Update mrbind: table-driven Python bindings registration - #6544
Open
Fedr wants to merge 5 commits into
Open
Conversation
Folds byte-identical template instantiations: mrmeshpy.so -11% unpacked, -2.3 MB compressed per wheel; full distro test matrix passed on an ICF build.
Points thirdparty/mrbind at MeshInspector/mrbind#42 (branch table-driven-py-registration); to be re-pointed at the merged master commit once that PR lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
thirdparty/mrbindto pick up MeshInspector/mrbind#42 (table-driven Python bindings registration). Originally stacked on #6535'sbindings-icf; that PR has merged, so this now targets master and the combined numbers below reflect both changes together.Note: the gitlink currently points at the mrbind PR branch head (8f8b1b6f); it will be re-pointed at the merged mrbind master commit once mrbind#42 lands, before this PR merges.
Measured effect (same-commit A/B vs pre-ICF master)
Manylinux dry runs 31128567300 (this mrbind commit) vs 31126757168 (master baseline):
mrmeshpy.socompressed in wheelmrmeshpy.so.textmrmeshpy.pyiis byte-identical to master's on x86_64; behavior is unchanged (the Python test suite passed on all 14 manylinux legs, and a full-platform dry run 31129376919 incl. Windows and macOS was green).Combined with ICF (#6535)
Stacked measurement (this PR on top of #6535's ICF), dry run 31156684018: x86_64
mrmeshpy.so12.39 MB zip / 51.5 MB raw — vs 19.32 MB master and 14.80 MB table-driven-alone. The two changes compose almost perfectly (−35.8% zip combined); ICF retains its full ~2.4 MB on top of the table rework.🤖 Generated with Claude Code