feat(app): gallery presentation mode (draft) - #1
Draft
MerpGoaterman wants to merge 2 commits into
Draft
MerpGoaterman wants to merge 2 commits into
MerpGoaterman wants to merge 2 commits into
Conversation
Introduce a dual-view Present toggle on gallery views: compact gallery stays unchanged, while Present opens a separate full-viewport slide experience with large typography and keyboard navigation. Co-authored-by: MerpGoaterman <MerpGoaterman@users.noreply.github.com>
happy-dom exposes contentEditable without isContentEditable, so ignore keys when the property or attribute is true. Also tidy slide padding classnames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes teableio#3660
Draft scaffold for a dual-view gallery Presentation mode for shared-screen review. This is not a zoomed-in gallery tile.
Canonical upstream PR: teableio#3661 (this fork PR is a local mirror).
UX
Gallery now has two distinct modes, switched by a Present toggle:
GalleryViewBase/Cardare untouched).Controls
State is local UI only (not a persisted view option).
Verification
vitest run src/features/app/blocks/view/gallery/utils/presentation.spec.ts— 13/13 passedOut of scope (follow-ups)