Skip to content

merge queue: checking #12781 on main (88fe2f7) - #12792

Closed
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/36ca7b61f2
Closed

merge queue: checking #12781 on main (88fe2f7)#12792
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/36ca7b61f2

Conversation

@mergify

@mergify mergify Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged soon. 🎉

#12781 is queued for merge on branch main (88fe2f7).

This pull request has been created by Mergify to check the mergeability of #12781.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: 88fe2f74b25afa46e70146888d40f16dfcbce9e4
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 12781
    scopes: []
scopes: []
...

flagendijk89 and others added 2 commits September 11, 2026 16:08
@flagendijk89
feat(scopes): tab the three CI systems instead of stacking them
edf9e13 
Every scopes page documents the same pipeline three times — GitHub
Actions, Buildkite, Any CI — one after another. A reader runs one of the
three and scrolls past the other two. The Bazel page rendered 11,339px
tall, most of it pipelines that reader will never use.

The three sections become a tab set:

  bazel   11,339px -> 8,551px
  pants    7,748px -> 4,732px
  nx       4,465px -> 2,579px

The markup does not change. `<CITabs>` wraps the region and a script
promotes each `###` inside it to a tab at runtime, which keeps three
things working that a build-time tab set would have broken:

  - With JavaScript off, or before the script runs, the page is what it
    was: three headings and their content, in order. Nothing is hidden
    by CSS, so a fallback reader never loses a pipeline.
  - Pagefind indexes the built HTML, so all three sections stay
    searchable. Hiding happens after the index is written.
  - Every link into a hidden panel still lands: the right-hand table of
    contents, a search result, and prose that cross-references another
    tab.

That last one needs a capture-phase click listener, not `hashchange`.
Astro's ClientRouter intercepts same-page anchor clicks and moves the
URL with pushState, which fires no hashchange at all, so a hashchange
handler alone left the table of contents doing nothing: the URL changed
and the page sat still. Capturing the click means the panel is open
before the router or the browser tries to scroll. `hashchange` stays for
back/forward.

The panel's first heading stays visible. Hiding it as a duplicate of the
tab label took it out of flow, and it is the element every one of those
links targets — so there was nothing correctly positioned left to scroll
to.

The chosen tab persists across pages: someone reading the Bazel page on
Buildkite is reading the Nx page on Buildkite too. Following a link into
a panel does not overwrite that choice, only clicking a tab does.

The styles are global, in `index.css`, not scoped to the component.
Astro scopes a component's CSS by stamping an attribute onto the
elements in its template, then drops any selector matching none of them
— and every element here is built at runtime, so a scoped block is
tree-shaken out of the build entirely. That shipped a tab strip with no
styles at all. `.dg` is global for the same reason, its markup coming
from a remark plugin rather than a template.

The strip is a segmented control rather than a row of underlined words.
Underlined text sits too close to how links already read on these pages
for the strip to be recognisable as one control with one option chosen.

Prose that pointed at a pipeline's position is reworded. "The pipelines
below", "as shown below", "the recipes above" all described a vertical
stack, and once the sections are siblings in a tab strip they resolve to
nothing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Change-Id: I9e3e85195eedf68b43d4ec11c05a53b5699d1176
Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
@mergify
Merge of #12781
52e9187
@mergify
mergify Bot deployed to Mergify Merge Protections September 11, 2026 15:21 Active
@mergify mergify Bot mentioned this pull request Sep 11, 2026
Merged
@mergify mergify Bot closed this Sep 11, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/36ca7b61f2 branch September 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@flagendijk89