merge queue: checking #12782 on main (65b5e32) - #12790
Closed
mergify[bot] wants to merge 2 commits into
Closed
Conversation
Two things on the Merge Queue hub were built inline in the MDX, and between them they were the last content file on the site reaching for `--color-*` primitives directly. The headline figures. The homepage and the hub carry the same three numbers — 3-5×, 60-90%, 0 — and drew them differently: the homepage through `.home-metrics-strip` in index.css with semantic tokens, the hub through nested divs with inline styles, hardcoded padding, radius and font sizes, numerals at weight 700 where the type scale's 1.5rem step is 500, and teal pulled from a primitive. Being inline it could not pick up the dark-mode remap the way every other surface does, so the same claim read as a different kind of object depending which page you came from. Both pages now render <MetricStrip>, which owns the markup and the styles the homepage already had; the superseded rules leave index.css. The comparison marks. The yes/no marks in "Mergify vs GitHub Native Merge Queue" were two `export const` arrow functions inside the MDX, each with a hand-written inline <svg> and its color in a style attribute, duplicating marks already in the site's icon set. <Verdict> replaces them, drawing from astro-icon. Its color stays a product primitive rather than a --theme-* token, because yes and no are a semantic pair with no semantic token behind them and DESIGN.md allows a primitive inside a component for that; what changes is that the content file no longer carries one. merge-queue.mdx loses about 90 lines of inline markup and styling, and `src/content/docs/` is now free of `--color-*` entirely. The tables are untouched. Glossary and the symptom/cause/help table are genuinely tabular and read better as tables than as cards. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Change-Id: Ida30f19564a144a12561edd3215e324bd049e9d7 Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#12782 is queued for merge on branch main (65b5e32).
This pull request has been created by Mergify to check the mergeability of #12782.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 1author = dependabot[bot]author = renovate[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = diagram-tokenscheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 1author = dependabot[bot]author = renovate[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = diagram-tokenscheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-botauthor != renovate[bot]head ~= ^docs-agent/