Fix #1888: [Bug] test_system_parser.py: SystemParser.__init__() got an unexpected keyword a#1889
Open
Memtensor-AI wants to merge 1 commit into
Open
Fix #1888: [Bug] test_system_parser.py: SystemParser.__init__() got an unexpected keyword a#1889Memtensor-AI wants to merge 1 commit into
Memtensor-AI wants to merge 1 commit into
Conversation
…ation - SystemParser.__init__() signature changed to (embedder, llm=None) - Test was still passing chunker=None causing TypeError - Fixes all 5 failing tests in test_system_parser.py Fixes #1888
Collaborator
Author
✅ Automated Test Results: PASSEDAll tests passed (35/35 executed, 36 skipped). memos_local_plugin/smoke: 0 passed, 1 skipped, memos_local_plugin/contract: 35 passed, 35 skipped. Duration: 4s Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed all 5 failing tests in test_system_parser.py by removing the invalid
chunkerparameter from SystemParser instantiation.Root Cause
The
SystemParser.__init__()method signature was refactored to accept(embedder: BaseEmbedder, llm: BaseLLM | None = None), removing thechunkerparameter. However, the test file at line 20 still used the old signatureSystemParser(embedder=self.mock_embedder, chunker=None), causing a TypeError for all 5 test methods.Changes Made
tests/mem_reader/test_system_parser.pychunker=Noneargument from line 20 in thesetUp()methodVerification
src/memos/mem_reader/read_multi_modal/system_parser.py:34Tests Fixed
This fix unblocks CI for all branches including dev and all AutoDev PRs.
Related Issue (Required): Fixes #1888
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Executor did not report tests.
Checklist
@MatthewZhuang, @CarltonXiang, @syzsunshine219 please review this PR.
Reviewer Checklist