Repository navigation
fix(up): resolve relative bind mounts from compose file directory - #164
Open
SomSamantray wants to merge 1 commit into
Open
SomSamantray wants to merge 1 commit into
SomSamantray wants to merge 1 commit into
Conversation
Owner
|
Hi! Thanks for the PR. Can please explain what the actual issue you are trying to solve is? |
Author
|
I opened this PR to fix relative bind mounts such as The existing code already uses the Compose file directory for service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary
Running
container-compose up -f deploy/docker-compose.ymlfrom the project root resolves a bind mount source like../dataagainst the process CWD. That points outsideproject/, so the wrong, often empty directory is mounted. Relative bind-mount sources should resolve from the Compose file directory, as Docker Compose does.Motivation and Context
build.contextand serviceenv_filealready resolve relative to the Compose file directory. Bind-mount sources were the exception. Fixes #147.What changed
Pass the selected Compose file directory to volume resolution so relative bind-mount sources resolve against it. Add static and container-backed regression coverage for
../data:/datawithuplaunched from the project root.Testing
data/marker.txtfrom the mount.action_requiredpending maintainer approval; the container-backed regression also requires macOS with Apple Container support.Code of Conduct
Prepared with OpenAI Codex; this revision by OpenAI Codex CLI with gpt-6-luna.