Repository navigation
Keep direct assignments for custom fetcher responses to avoid a slowdown - #123
Merged
Merged
Conversation
size-limit report 📦
|
This was referenced Sep 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request undoes one change of #121, which saved a few bytes but made requests measurably slower. It targets the 4.3.0 release pull request #120.
🐛 Bug Fixes
prepareResponse()with oneObject.assign()of an object literal, which allocates an extra object for every response. In a benchmark comparing the builds before and after Reduce the bundle size without changing behavior #121,fetchf()with config options and interceptors was 2.4% slower (the median of 8 rounds, alternating which build ran first). With this change it's back to +0.7%, which is within the noise.fetchf()andbuildConfig()were within the noise.🧪 Tests
📦 Bundle Size
The bundles grow by about 10 bytes (brotli), e.g.
browser/index.mjsfrom 7.97 kB to 7.98 kB. That's still 0.16 kB smaller than before #121, and the README's 8.9 KB for fetchff doesn't change.Generated by Claude Code