[1.x] EbmlHead: do not allow to have an infinite/unknown size#328
Merged
Conversation
It does not have [^1] unknownsizeallowed set to true (default to false) [^1]: https://www.rfc-editor.org/rfc/rfc8794.html#section-11.2.1
robUx4
added
the
abi-break
Contributor
Author
|
On the 2.x branch the unknownsizeallowed capability is hardcoded in each element definition. |
ePirat
pushed a commit
to videolan/vlc
that referenced
this pull request
Apr 30, 2026
This will allow false detection of an invalid EBML header. Submitted upstream [^1] but will need a new release as it might break the ABI. Ref. #29578 [^1]: Matroska-Org/libebml#328
Contributor
Author
|
According to abidiff this is not an ABI breakage. Although as seen in Matroska-Org/libmatroska#242 it's not entirely reliable. |
ePirat
pushed a commit
to videolan/vlc
that referenced
this pull request
May 7, 2026
This will allow false detection of an invalid EBML header. Submitted upstream [^1] but will need a new release as it might break the ABI. Ref. #29578 [^1]: Matroska-Org/libebml#328 (cherry picked from commit a8da8dc) Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
Contributor
|
As the function in the base class is already Technically, this means that there's already been an entry in the class's Semantically I agree with the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does not have 1 unknownsizeallowed set to true (default to false)
Footnotes
https://www.rfc-editor.org/rfc/rfc8794.html#section-11.2.1 ↩