SS-348: Avoid eager materialization of diff pairs in iter_diff_pairs#37817
Merged
martykulma merged 1 commit intoJul 23, 2026
Merged
Conversation
- returns an Iterator instead of a Vec - adds a unit test to validate a cap on clones
martykulma
changed the title
martykulma
marked this pull request as ready for review
July 23, 2026 11:47
Contributor
Author
|
The test failures don't appear to be related to the change (the |
Contributor
|
Nightly failures are indeed unrelated, fixed in #37822 |
patrickwwbutler
approved these changes
Jul 23, 2026
patrickwwbutler
left a comment
patrickwwbutler
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Agreed that test failures on nightly seem unrelated
Contributor
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip materialization of diff pairs (i.e. collect()) as it causes memory bloat in some cases. This PR changes the return type to a lazy iterator and adds a unit test to validate the issue and confirm the fix.
ref: @def- found a pathological case in refactor of for_each_diff_pair that results in high memory usage shortly after it was merged.