compute: Retire the fueled as_specific_collection flag#37792
Draft
antiguru wants to merge 1 commit into
Draft
Conversation
antiguru
force-pushed
the
columnar-tc-retire-fueled-flag
branch
from
July 22, 2026 08:41
ffb77b9 to
336d138
Compare
antiguru
force-pushed
the
columnar-tb-join-accumulator
branch
from
July 22, 2026 08:41
7323a80 to
083529c
Compare
antiguru
force-pushed
the
columnar-tb-join-accumulator
branch
from
July 22, 2026 16:24
083529c to
d299f39
Compare
antiguru
force-pushed
the
columnar-tc-retire-fueled-flag
branch
from
July 22, 2026 16:24
336d138 to
9a5a05a
Compare
`as_specific_collection`'s keyed path was gated on `ENABLE_COMPUTE_RENDER_FUELED_AS_SPECIFIC_COLLECTION` (default true): the fueled branch packs the arrangement cursor into a `ColumnBuilder` and returns the columnar edge, while the off branch called the deprecated `ArrangementFlavor::as_collection` and returned a real-data `Vec`. The off branch was the last non-leaf real-data `Vec` producer. The fueled path is a complete functional replacement: it materializes every `(row, t, diff)` from the same cursor with all columns decoded, so production (flag on) already used it. Delete the off branch, always take the fueled columnar path, and retire the flag from `dyncfgs.rs`, its config-set registration, and the LaunchDarkly and parallel-workload flag lists. With the flag gone, `ArrangementFlavor::as_collection` has no callers, so remove it. The `config_set` argument then existed only to reach the flag, threaded through `as_specific_collection` and `as_collection_core` (whose sole `config_set` use was forwarding it), so drop it from both signatures and their callers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
antiguru
force-pushed
the
columnar-tc-retire-fueled-flag
branch
from
July 22, 2026 17:50
9a5a05a to
ea705b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the
enable_compute_render_fueled_as_specific_collectionflag and its flag-off branch. The flag has defaulted on since the arrangement-materialization flip (P5).Columnar dataflow-edge migration. Design doc:
doc/developer/design/20260720_columnar_dataflow_edges.md(#37744).Part of CPU-51.