sqlsmith: extend harness and fix error handling#37562
Merged
Merged
Conversation
def-
force-pushed
the
sqlsmith-improvements
branch
4 times, most recently
from
July 10, 2026 14:24
9674ffa to
7054033
Compare
Propagate SQLsmith thread failures (OOM, bad return codes) instead of silently swallowing them, fix the broken --exclude-catalog flag, and lock the shared result aggregate. Extend coverage: seed data with NULLs, edge values, an empty and a 10k row table, indexes, and list/map/array/range columns. Run two instances per server, every fourth one as an unprivileged role with RBAC checks enabled. Print SQLsmith's impedance stats so blacklisted grammar productions become visible. Suppress the type-unification error family that the extended SQLsmith grammar (joins, GROUP BY, set ops, WITH MUTUALLY RECURSIVE, window functions) triggers. The grammar changes are in MaterializeInc/sqlsmith and need a Dockerfile pin bump once merged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
def-
force-pushed
the
sqlsmith-improvements
branch
from
July 10, 2026 22:13
7054033 to
733d4ae
Compare
def-
marked this pull request as ready for review
July 11, 2026 06:39
ggevay
approved these changes
Jul 13, 2026
def-
added a commit
that referenced
this pull request
Jul 14, 2026
…oMs (#37630) Seen in https://buildkite.com/materialize/test/builds/128284 Merge skew between #37436 and #37479 The sqlsmith one is fallout from #37562, which of course was green there and then immediately went OoM twice on main!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate SQLsmith thread failures (OOM, bad return codes) instead of silently swallowing them, fix the broken --exclude-catalog flag, and lock the shared result aggregate.
Extend coverage: seed data with NULLs, edge values, an empty and a 10k row table, indexes, and list/map/array/range columns. Run two instances per server, every fourth one as an unprivileged role with RBAC checks enabled. Print SQLsmith's impedance stats so blacklisted grammar productions become visible.
Suppress the type-unification error family that the extended SQLsmith grammar (joins, GROUP BY, set ops, WITH MUTUALLY RECURSIVE, window functions) triggers. Using MaterializeInc/sqlsmith#7
Test runs: https://buildkite.com/materialize/release-qualification/builds/1310 & https://buildkite.com/materialize/nightly/builds/17150 (both green)