[rockfordlhotka]

Summary

• SafeDataReader has async members:
  • ReadAsync, NextResultAsync and CloseAsync.
  • IsDBNullAsync and GetFieldValueAsync<T>, by ordinal or by column name.
  • Async versions of the typed getters that return defaults for nulls, the same as the sync getters: GetStringAsync, GetValueAsync, GetInt16/32/64Async, GetDoubleAsync, GetFloatAsync, GetDecimalAsync, GetBooleanAsync, GetByteAsync, GetGuidAsync, GetDateTimeAsync, GetDateTimeOffsetAsync and GetSmartDateAsync.
  • IAsyncDisposable (DisposeAsync).
• The new members use the underlying DbDataReader, which every ADO.NET provider returns. If the wrapped reader isn't a DbDataReader, they run synchronously.
• The typed getters check for null asynchronously and then call the provider's typed getter. A plain (T) cast would fail where a provider returns a different type: SQLite returns long for INTEGER columns.
• SafeSqlDataReader now inherits ReadAsync, NextResultAsync and GetFieldValueAsync<T> instead of declaring SqlClient-only versions. It keeps IsDbNullAsync, marked [Obsolete], which forwards to IsDBNullAsync.
  • Breaking change: code compiled against the old SafeSqlDataReader async methods must be recompiled. Source code is unchanged.
• Release notes and Upgrading to CSLA 11.md are updated.

Test plan

• csla.build.sln builds for all targets (netstandard2.0, net462 to net48, net10.0, net11.0).
• New SafeDataReaderAsyncTests run against SQLite and pass on net10.0 and net11.0. They cover:
  • reading rows and moving between result sets;
  • typed values and the defaults returned for nulls;
  • cancellation;
  • CloseAsync and DisposeAsync;
  • the synchronous fallback for readers that aren't a DbDataReader.
• Full csla.test.sln suite (TestCategory!=SkipOnCIServer) passes.

Closes #4975

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

Async disposal can skip subclasses’ unmanaged-resource cleanup, and the upgrade guide omits required source-compatibility changes.

2 open issues

• Async disposal skips subclass unmanaged cleanup · New
• Document source-breaking async API changes · New

What changed in this PR

Adds async support to CSLA’s SafeDataReader, addressing #4975 while preserving null-safe typed getters and synchronous fallback for readers that are not DbDataReader.

Changes:

• Adds async navigation, value access, closing, and disposal.
• Moves shared async methods from SafeSqlDataReader into the base reader and deprecates IsDbNullAsync.
• Adds SQLite-backed tests and documents the new APIs and migration requirements.

File	Description
Source/​tests/​Csla.test/​SafeDataReader/​SafeDataReaderAsyncTests.cs	Tests async getters, navigation, cancellation, cleanup, and fallback behavior.
Source/​Csla/​Data/​SafeDataReader.cs	Implements async reader APIs and IAsyncDisposable.
Source/​Csla.Data.SqlClient.Fx/​SafeSqlDataReader.cs	Inherits shared async methods and retains obsolete null-check aliases.
releasenotes.md	Announces async support and compatibility changes.
docs/​Upgrading to CSLA 11.md	Provides usage examples and migration guidance.

_{Review effort: Balanced}