Extend the issue rules to the proposed fix, and to stale evidence - #34
Merged
Merged
Conversation
The "verify before filing" rule covered the cause. Three issues picked up this week showed the same failure in the half it did not cover. #21's mock-up listed Cancel first "so it is the default"; MessageBox defaults to the last button, so implementing the issue as written armed a reflexive Enter to delete — the exact outcome the prompt existed to prevent. #26 reasoned that a release's --version output could not change, which held for 0.3.0 and not for 0.2.0-rc.1. Both were assumptions about a framework nobody had run, and both read as findings. #1 added a third shape: its evidence had rotted. It cited src/Application/Samples/basket.xml as a second reproducing document, and that file went with the WinForms tree months earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only — amends the issue-tracker conventions in
CLAUDE.md.The existing "verify before filing, and label a theory as a theory" rule covered the cause.
Three issues picked up this week showed the same failure in the half it did not cover: the
proposed fix.
last button, so implementing the issue as written shipped
⟦► Delete ◄⟧, arming exactly thereflexive Enter the confirmation existed to prevent. Caught only by looking at a real terminal.
--versionoutput could not change. True for0.3.0, falsefor
0.2.0-rc.1; it also missed that the SDK appends+<sha>, which would have broken the nextrelease rather than a test.
Both were assumptions about a framework nobody had run, and both read as findings.
#1 added a third shape: its evidence had rotted. It cited
src/Application/Samples/basket.xmlas a second reproducing document, and that file went with the WinForms tree in
1ad7cf6— so halfthe issue's evidence could not be reproduced from the repo at all.
Two bullets, both anchored to those cases so the rule carries its own evidence.
🤖 Generated with Claude Code
https://claude.ai/code/session_016X4pgrsMBcsXjqWDo2gBBt