feat(helm): readiness rootca cleanup - #32
Merged
Merged
Conversation
Add a readinessProbe (httpGet / on 8080) so rolling updates and the Route stop sending traffic to pods before the app is up. Replace the blanket NODE_TLS_REJECT_UNAUTHORIZED=0 (disabled all outbound TLS verification) with proper trust: a global.ca block referencing a pre-existing root-ca Secret, mounted into the pod and exported via NODE_EXTRA_CA_CERTS. Gated on global.ca.secretName; set empty to disable. Follows the docker-mapproxy convention. Remove leftover nginx scaffolding (commented volume/volumeMount blocks and the default.conf configmap entry) — this is a Node/SvelteKit app. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a startupProbe (httpGet / on 8080) that gates liveness and readiness until the app has booted, giving up to ~5m (30x10s) plus the existing initialDelaySeconds grace. Move initialDelaySeconds onto the startupProbe and drop it from livenessProbe so liveness reacts quickly to hangs once the container is up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The CA mount path and key never vary; only the source Secret name does. Inline /usr/local/share/ca-certificates/ca.crt and drop global.ca.path / global.ca.key, leaving global.ca.secretName as the sole knob. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collapse the multi-line explanatory comments to one-liners and drop pure narration, keeping only what isn't clear from the keys themselves: the external-Secret key contracts, the '' toggle semantics, dark-by-default agent, and the proxy origin override. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.