Skip to content

Fix segfault in Record.get() with invalid positional argument count #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apoorvdarshan wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Fix segfault in Record.get() with invalid positional argument count #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions asyncpg/protocol/record/recordobj.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,7 @@ record_get(PyObject *self, PyTypeObject *defcls, PyObject *const *args,
PyErr_Format(PyExc_TypeError,
"Record.get() expected 1 or 2 arguments, got %zd",
nargs);
return NULL;
}

if (kwnames != NULL && PyTuple_GET_SIZE(kwnames) != 0) {
Expand Down
10 changes: 10 additions & 0 deletions tests/test_record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,16 @@ def test_record_get(self):
self.assertEqual(r.get('nonexistent'), None)
self.assertEqual(r.get('nonexistent', 'default'), 'default')

def test_record_get_invalid_args(self):
r = Record(R_AB, (42, 43))
with self.checkref(r):
with self.assertRaises(TypeError):
r.get()
with self.assertRaises(TypeError):
r.get('a', 2, 3)
with self.assertRaises(TypeError):
r.get(default=2)

def test_record_not_pickleable(self):
r = Record(R_A, (42,))
with self.assertRaises(Exception):
Expand Down