Repository navigation
Add Android wheels #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+186
−155
Merged
Add Android wheels #289
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9e9edd5
Add Android wheels
mhsmith 0ef1047
Merge remote-tracking branch 'origin/main' into android
mhsmith 1836f2c
Temporarily run workflows on all branches
mhsmith 0c75995
Linux and macOS fixes
mhsmith 8da2f0a
Windows fixes
mhsmith c1b4e59
Linux emulation and Windows ARM64 fixes
mhsmith 5d92f36
Windows ARM debugging
mhsmith bb49192
Windows ARM fixes
mhsmith ea560de
Revert temporary changes
mhsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,4 @@ local/scipy_openblas64/*.so | |
| local/scipy_openblas64/*.pyd | ||
| local/scipy_openblas64/*.dylib | ||
| objconv/ | ||
| wheelhouse/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,9 @@ | ||
| #!/bin/bash | ||
| # Test that the wheel works with a different python | ||
| set -xe | ||
|
|
||
| if [ "${PLAT}" == "arm64" ]; then | ||
| # Cannot test | ||
|
Comment on lines
-5
to
-6
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess this was a leftover from when GitHub Actions didn't have ARM64 runners, because it works fine now. |
||
| exit 0 | ||
| fi | ||
|
|
||
| PYTHON=python3.9 | ||
| if [ "$(uname)" == "Darwin" -a "${PLAT}" == "x86_64" ]; then | ||
| which python3.9 | ||
| PYTHON="arch -x86_64 python3.9" | ||
| PYTHON=python3 | ||
| if [ "$CIBUILDWHEEL_BUILD_IDENTIFIER" = "macosx_x86_64" ]; then | ||
| PYTHON="arch -x86_64 python3" | ||
| fi | ||
|
|
||
| # Make sure the module works and that the version strings match | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment was ever true: the build and test previously both used Python 3.9, and now they're using Python 3.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once upon a time we built the wheel with 3.9 and tested with 3.11, but the move to 3.13 kind of messed that all up.