Fix MOAB partitioning for single a core#184
Merged
Merged
Conversation
mbpart refuses to create a single partition ("Please specify #parts = 1
to be greater than 1"), so building a mapping file with map_tool='moab'
and ntasks=1 failed. Skip the mbpart step and pass the unpartitioned
.h5m mesh to mbtempest when there is only one task.
The mbconvert step is kept at all task counts. Loading SCRIP files
directly into mbtempest is not a viable alternative: mbtempest aborts
while computing weights when a mesh with more than 4 vertices per cell
(e.g. an MPAS cell mesh) is loaded from SCRIP as the destination mesh.
This is independent of the NetCDF format of the SCRIP file.
Add unit tests that check the commands pyremap constructs for moab and
esmf at one and two tasks, with check_call mocked so no MOAB or ESMF
binaries are needed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mbpartrefuses to create a single partition ("Please specify #parts = 1 to be greater than 1"), so building a mapping file withmap_tool='moab'andntasks=1failed. Skip thembpartstep and pass the unpartitioned.h5mmesh tombtempestwhen there is only one task.The
mbconvertstep is kept at all task counts. Loading SCRIP files directly intombtempestis not a viable alternative:mbtempestaborts while computing weights when a mesh with more than 4 vertices per cell (e.g. an MPAS cell mesh) is loaded from SCRIP as the destination mesh. This is independent of the NetCDF format of the SCRIP file.Add unit tests that check the commands pyremap constructs for moab and esmf at one and two tasks, with check_call mocked so no MOAB or ESMF binaries are needed.