ci(release): do not repeat a release that is already underway - #110
Merged
Merged
Conversation
Preparing a release triggered on any push to the release branch, so hand-editing the generated changelog on that branch prepended a second section for the same version and failed trying to open a pull request that already existed. The release is now prepared only when the release branch is first pushed, leaving the branch open to corrections before it is merged. Skipping an already released version reported success, so a later push to main would attempt to upload the same version to PyPI again and open a second pull request resetting develop. The release job now reports whether it created a release, and the publish and reset jobs check it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects in #108, both reachable while cutting 1.0.0.
mainwould attempt to upload the same version to PyPI again and open a second pull request resettingdevelop. The release job now reports whether it created a release, and the publish and reset jobs check it.