chore(dependencies): test against the released xmipy, bound dependencies - #109
Merged
Merged
Conversation
The extensions tests installed xmipy from its develop branch, so no job ran against the xmipy a user gets from PyPI. Nothing in modflowapi needs the development branch: modflowapi uses XmiWrapper and errors.InputError, and xmipy develop is six commits ahead of 1.5.0, none of which touch the library. The tests now run against the released xmipy. Dependencies were unbounded. Lower bounds are the oldest releases that install on Python 3.11, the minimum this package supports, so nothing resolvable is excluded. The development status classifier was still beta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for a 1.0.0 release.
developbranch, so no job ran against the xmipy a user gets from PyPI. Nothing in modflowapi needs it — modflowapi usesXmiWrapperanderrors.InputError, and xmipydevelopis six commits ahead of 1.5.0, none of which touch the library.Development Status :: 4 - Betabecomes5 - Production/Stable.Removing the
developinstall drops an early warning of breakage in unreleased xmipy. If that is worth keeping it belongs in a scheduled job that is allowed to fail, not in the pull request checks.