fix(dfns): fix olf idcxs fk backfill, trim migration comments - #350
Merged
Conversation
wpbonelli
commented
Aug 22, 2026
wpbonelli
commented
Member
- olf-zdg/olf-dfw's idcxs fk pointed at a nonexistent olf-cxs component; retarget to chf-cxs and drop the dead swf-* entries
- trim excessive comments in the v2 migration
OLF has no cross-section component of its own (c92f3e51, "remove olf-cxs.dfn": "Overland flow has no concept of cross section"), but olf-zdg/olf-dfw's idcxs field still indexes into a shared SwfCxsType object at the Fortran level (swf-zdg.f90) -- the same cross-section data CHF's own zdg/cdb reference. Point the fk at chf-cxs instead of a component that was never real. Also drop the swf-zdg/swf-dfw entries entirely -- SWF was split into CHF/OLF and removed (802d8e1d), so there's no swf-* component left to backfill. Surfaced building flopy4's mf6 codegen against a live modflow6 develop checkout: Dfns(components=...) hard-fails construction when any fk target doesn't resolve, and it doesn't, for any corpus that reflects current (post-split) modflow6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.