Skip to content

fix(phase_change): globalize pTg/TSat Newton solvers so they converge (esp. GPU) #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbryngelson wants to merge 5 commits into
base: master
Choose a base branch
from
+1,005 −1,130
Open

fix(phase_change): globalize pTg/TSat Newton solvers so they converge (esp. GPU) #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
208e9c3
fix(phase_change): bound Newton relaxation loops by max_iter (#1646)
sbryngelson Jul 17, 2026
c392268
fix(phase_change): globalize the pTg/TSat Newton solvers so they actu…
sbryngelson Jul 17, 2026
2533dd6
fix(phase_change): always solve pTg equilibrium in model-6 (fix CPU/G…
sbryngelson Jul 17, 2026
e518436
Merge remote-tracking branch 'upstream/master' into fix-phasechange-n…
sbryngelson Jul 17, 2026
1657e52
test(phase_change): regenerate phasechange_bubble example goldens for…
sbryngelson Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
411 changes: 131 additions & 280 deletions src/common/m_phase_change.fpp
View file
Open in desktop

Large diffs are not rendered by default.

181 changes: 92 additions & 89 deletions tests/02BD9B5E/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 20 additions & 20 deletions tests/02BD9B5E/golden.txt
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading