Repository navigation
Preserve vault owner notices without Essentials mail API - #8
Draft
ParadauxIO wants to merge 1 commit into
Draft
ParadauxIO wants to merge 1 commit into
ParadauxIO wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
VaultStorage 1.2.0 resolves
MailServiceduringonEnable, so an Essentials build without its mail API prevents startup before the optional provider check. Vault creation also calls that removed API for owner notices. This narrowly addresses ADT-206.How?
Use the existing PlayerNotifications mail inbox for owner notices, preserving the configured template, sender, recipient, text and formatting. Save each notice before delivery; retain it for retry after restart or once a minute if the optional API/service is unavailable or rejects delivery. Inbox entries do not expire or overwrite earlier notices. A queue write failure reports the unsaved notice without undoing the already-created vault. Existing mail is never read, converted or deleted.
The branch starts from matching
1.21.8; storage, capture, ownership, inventory and protection logic are retained. Java 25 is used for the PlayerNotifications API and CI.Validation: checked-in Gradle wrapper clean build and six durable-queue tests pass. Isolated checks against the actual Paper 26.3 dependency classpath and the Essentials candidate exercise real
onEnable, vault creation/ownership/inventory, unavailable notifications, and absent PlayerNotifications classes. The frozen original fails the missing-API control; all 166 other original VaultStorage classes remain byte-identical. No live runtime or data changes were performed. Draft only; dependent readiness and deployment remain separate.Diagram
Diagram
The vault remains stored while its notice either reaches the inbox or stays queued for retry.
Screenshots
Not applicable: this changes startup and offline notification delivery, with no visual interface change. Authenticated gameplay remains unverified.