Repository navigation
Modernize MusicBox for Paper 26.3 and Java 25 - #1
Draft
ParadauxIO wants to merge 5 commits into
Draft
ParadauxIO wants to merge 5 commits into
ParadauxIO wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
MusicBox's version-specific NMS and XSeries initialization prevent it from running on current Paper. This fork targets Paper 26.3+ and Java 25 while keeping existing songs, discs, signs, and player playlists.
How?
paper-plugin.ymland Cloud commands undercom.minecraftcitiesnetwork.musicbox.musicbox:song_hash, path-derived song/folder IDs, config keys, sign formats, and SQLite schema. Retain unresolved playlist and sign references instead of deleting them during recovery.Validation: a clean build using Java 25 and Paper API
26.3.build.206-stablepassed all 23 regular tests, plus 3 native Paper bootstrap checks, with zero failures or skips. The bootstrap checks exercise real Minecraft registries, the item parser, native PaperCommandManager construction, and all 17 MusicBox command forms without starting a server. A Cloud beta.10 negative control fails these checks; Cloud 2.0.1 passes. Coverage includes Cloud dispatch/permissions, synthetic NBS decoding and path hashes, SQLite retention and sparse ordering, raw/PDC disc tags, lifecycle guards, sign recovery, economy availability, and jukebox item conservation. Artifact inspection verified Java 25 bytecode, native metadata, shaded Cloud, and no bundled example songs or old compatibility libraries. Native Paper 26.3 enable, console help, and reload smoke checks pass, including song reload and GUI initialization without errors. Direct live song count and audible playback have not been verified. Authenticated GUI, discs, signs, redstone, jukebox/chest, and economy checks remain pending. This PR remains draft and must not be merged as part of deployment verification.Diagram
Diagram
The native Paper entry points share existing playback and persistence contracts.
Screenshots
In-game GUI/playback captures are pending authenticated client verification.