Find pg_ctl on PATH in the native cluster test - #111
LucaCappelletti94 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 84.64% 84.61% -0.03%
==========================================
Files 131 131
Lines 31447 31453 +6
Branches 31447 31453 +6
==========================================
- Hits 26617 26615 -2
- Misses 3297 3303 +6
- Partials 1533 1535 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
The native cluster test in the test harness looked for the PostgreSQL server programs only where Debian and Ubuntu install them, so on a Mac it failed before starting anything, even with PostgreSQL installed through Homebrew.
The test now takes the directory of the
pg_ctlfound onPATHand falls back to the newest Debian install when there is none. The CI runners have nopg_ctlonPATH, so they keep using the Debian layout. The test passes on a Mac with Homebrew's PostgreSQL 14 and on Linux through the Debian layout.