Build every client through one builder per platform (R94) - #110
LucaCappelletti94 wants to merge 10 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 84.64% 84.74% +0.10%
==========================================
Files 131 142 +11
Lines 31447 33861 +2414
Branches 31447 33861 +2414
==========================================
+ Hits 26617 28695 +2078
- Misses 3297 3556 +259
- Partials 1533 1610 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
79f3222 to
c80e392
Compare
fc57656 to
e99c24b
Compare
|



Every client, whether native, a browser worker or a browser tab, is now built by one builder chain over the same schema, tuning and sign-in pieces, and
ClientConfig,ConnettoConnection::connectandConnettoClient::startare internal, so there is no second way to make one. The schema reaches the client as the one bundle the build step translates, so the replica DDL and the version the handshake checks cannot drift apart. A durable build is gated on the away-and-return re-check by default, a browser tab learns who its worker is signed in as, a native client forgets its device through the client itself, and a capability now travels only as a share key with its subject.Moving every test and demo onto the builders turned up four bugs, each fixed with a test. A running client waiting to redial neither queued local writes nor refreshed its live queries, a write made just before
close()could slip past the unsynced guard a sign-out reads, the file outbox never ended on close, and the Apple clock branch did not compile. The reference binary now translates its schema at runtime, takesCONNETTO_USERbeside the token, and lets the server answer its pushed writes before it exits on a refused one.The first commit only moves subql, sqlparser and diesel-sqlite-session in the seven lockfiles. Locally the full gate, every browser suite, the restore tests and the device proof on the Galaxy M52, the iOS simulator and an iPhone over
wss://all pass.