Survive a dropped adb link and a killed screen dump in the Android proof - #109
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 84.62% 84.59% -0.03%
==========================================
Files 130 130
Lines 31240 31240
Branches 31240 31240
==========================================
- Hits 26436 26428 -8
- Misses 3283 3289 +6
- Partials 1521 1523 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
The Android emulator proof failed twice on #107 for reasons outside the app. Once uiautomator's screen dump was killed while the proof looked for Chrome's first-run screens during sign-in, and that one failure aborted the whole proof. Once the emulator's adb link dropped right after the proof had passed, so restoring the default browser failed with a device offline error.
A failed screen dump is now logged and retried on the next pass of the existing 90-second search. An adb command that fails because the device went offline is retried once after resetting the connection and waiting up to 30 seconds for the device to answer, and every other adb failure still fails at once. If the device never comes back, the job still fails, as it should on a real phone.