Skip to content

PR 010 repair: tolerate Node type stripping warning - #20

Merged
LogicDuke merged 1 commit into
pr-010/commander-claude-bridgefrom
repair/pr010-cr3-type-stripping-warning
Aug 16, 2026
Merged

PR 010 repair: tolerate Node type stripping warning#20
LogicDuke merged 1 commit into
pr-010/commander-claude-bridgefrom
repair/pr010-cr3-type-stripping-warning

Conversation

@LogicDuke

@LogicDuke LogicDuke commented Aug 16, 2026

Copy link
Copy Markdown
Owner

CR-3 only.

This stacked validation PR repairs a CURRENT P3 test-compatibility defect in
tests/adapters/process-transport.test.ts.

The repository supports Node >=24 <25. Node 24.0–24.2 emits its own Type
Stripping ExperimentalWarning when the permission probe imports the TypeScript
transport source directly. Node 24.3.0 removed that warning.

The previous test required the probe interpreter's stderr to be completely
empty, causing a false failure on supported Node 24.0–24.2 even though the
transport and all environment/security invariants were correct.

The repair narrowly removes only the exact known Node Type Stripping warning
block before enforcing residual stderr == ''.

It does NOT suppress arbitrary stderr, unrelated ExperimentalWarning output,
stack traces, duplicate known warning blocks, orphan companion lines, or
near-match warning text.

Production code is unchanged.

N24-PERM-1 is unchanged and remains fixed.

Independent validation:
PASS

Validated diff SHA-256:
8ff92bb8810ffd78b240f2db2e25b997b061e593a2da3a6f70f4e65d6df4351d

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of Node.js type-stripping warnings across LF and CRLF line endings.
    • Preserved unrelated error output while removing only recognized warnings.
    • Prevented duplicate known warnings from affecting permission checks.
  • Tests

    • Added coverage for matching, lookalike, ordering, duplicate-warning, and permission-probe scenarios.

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fb819089-4645-499c-a90d-4df4cff4d83c

📥 Commits

Reviewing files that changed from the base of the PR and between 37e5ae2 and 1b6f109.

📒 Files selected for processing (1)
  • tests/adapters/process-transport.test.ts

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The test suite adds exact filtering for Node’s known type-stripping warning. It supports LF and CRLF output, preserves unrelated stderr, tests duplicate and incomplete warnings, and updates the permission-probe assertion.

Changes

Node warning filtering

Layer / File(s) Summary
Warning filtering contract and validation
tests/adapters/process-transport.test.ts
A helper removes only the first complete Node type-stripping warning block. Parameterized tests cover line endings, lookalikes, surrounding stderr, incomplete blocks, and duplicates. The permission-probe assertion uses the helper before checking stderr.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 1b6f1

This PR narrowly adjusts a test to ignore only the known Node type-stripping warning while preserving checks for other stderr output; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

  • LogicDuke/agentbridge#18: Both modify permission-probe assertions in the same test file, but address different Node behavior.

Poem

A bunny trims one warning line,
Keeps every other stderr sign.
LF and CRLF hop in tune,
Duplicate blocks stay marooned.
Tests guard the probe with care—
Clean output, fluffy air.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: repairing tests to tolerate Node's type-stripping warning.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch repair/pr010-cr3-type-stripping-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LogicDuke

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@LogicDuke

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 1b6f109474

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@LogicDuke
LogicDuke marked this pull request as ready for review August 16, 2026 11:51
@LogicDuke
LogicDuke merged commit 62ea4a1 into pr-010/commander-claude-bridge Aug 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant