PR 010 repair: tolerate Node type stripping warning - #20
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe test suite adds exact filtering for Node’s known type-stripping warning. It supports LF and CRLF output, preserves unrelated stderr, tests duplicate and incomplete warnings, and updates the permission-probe assertion. ChangesNode warning filtering
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR narrowly adjusts a test to ignore only the known Node type-stripping warning while preserving checks for other stderr output; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
CR-3 only.
This stacked validation PR repairs a CURRENT P3 test-compatibility defect in
tests/adapters/process-transport.test.ts.
The repository supports Node >=24 <25. Node 24.0–24.2 emits its own Type
Stripping ExperimentalWarning when the permission probe imports the TypeScript
transport source directly. Node 24.3.0 removed that warning.
The previous test required the probe interpreter's stderr to be completely
empty, causing a false failure on supported Node 24.0–24.2 even though the
transport and all environment/security invariants were correct.
The repair narrowly removes only the exact known Node Type Stripping warning
block before enforcing residual stderr == ''.
It does NOT suppress arbitrary stderr, unrelated ExperimentalWarning output,
stack traces, duplicate known warning blocks, orphan companion lines, or
near-match warning text.
Production code is unchanged.
N24-PERM-1 is unchanged and remains fixed.
Independent validation:
PASS
Validated diff SHA-256:
8ff92bb8810ffd78b240f2db2e25b997b061e593a2da3a6f70f4e65d6df4351d
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests