PR 013 repair: make no-spawn marker proof conclusive

[LogicDuke]

Stacked validation PR for the single CodeRabbit finding on PR #13. Makes the malformed-workingDirectory no-spawn marker assertion conclusive by pre-creating the U+FFFD-substituted directory, so a regression reaching spawn can execute and write the marker. Test-only repair, independently validated before commit. PR #13 and PR #10 remain protected until this child PR passes independent review and CI.

Summary by CodeRabbit

• Tests
  • Improved validation test coverage for ill-formed filesystem paths.
  • Added setup and cleanup for replacement directories to ensure failures are reported accurately.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bff4ef92-2f77-40e7-8441-ffdeb7a3a953

📥 Commits

Reviewing files that changed from the base of the PR and between fefd6db and 98a34be.

📒 Files selected for processing (1)

• tests/adapters/process-transport.test.ts

---

📝 Walkthrough

Walkthrough

The test now creates Node’s replacement directory before validating an ill-formed process path. Cleanup removes the directory after the test.

Changes

Process path validation

Layer / File(s)	Summary
Replacement directory test setup tests/adapters/process-transport.test.ts	The test imports mkdirSync, creates the replacement directory before assertions, and removes it during cleanup. This prevents a missing-directory spawn failure from masking path validation behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 98a34

This is a localized test-only change that strengthens a no-spawn assertion; no actionable merge-blocking risk remains, so it is merge-ready after normal checks.

Poem

I’m a rabbit who checks every path,
A tiny test avoids a spawn error’s wrath.
Make the odd directory, then clean it away,
So validation can have its say.
Hop, hop—the test is clear today!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the test repair that makes the no-spawn marker proof conclusive.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch repair/pr013-coderabbit-marker-proof

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[LogicDuke]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[LogicDuke]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 98a34be853

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".