Skip to content

feat(linux/wlr): enable Vulkan encoding for wlroots capture - #5734

Open
neatnoise wants to merge 1 commit into
LizardByte:masterfrom
neatnoise:feat/wlr-vulkan
Open

neatnoise wants to merge 1 commit into
LizardByte:masterfrom
neatnoise:feat/wlr-vulkan

Conversation

@neatnoise

Copy link
Copy Markdown
Contributor

Description

Enable Vulkan encoding for wlroots screencopy capture.

Query Vulkan driver for supported DRM format modifiers and intersect with compositor modifiers before creating GBM buffers. This ensures buffers use formats both sides can handle.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.05%. Comparing base (7c8926d) to head (a310931).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/vulkan_encode.cpp 0.00% 58 Missing and 1 partial ⚠️
src/platform/linux/wayland.cpp 0.00% 23 Missing and 2 partials ⚠️
src/platform/linux/wlgrab.cpp 0.00% 13 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5734      +/-   ##
==========================================
- Coverage   38.19%   38.05%   -0.15%     
==========================================
  Files         106      106              
  Lines       26403    26500      +97     
  Branches    11632    11688      +56     
==========================================
- Hits        10085    10084       -1     
+ Misses      14850    13534    -1316     
- Partials     1468     2882    +1414     
Flag Coverage Δ
Alpine-aarch64 23.09% <0.00%> (-0.14%) ⬇️
Alpine-x86_64 23.21% <0.00%> (-0.14%) ⬇️
Archlinux 21.86% <0.00%> (-0.14%) ⬇️
FreeBSD-amd64 23.82% <0.00%> (-0.15%) ⬇️
Homebrew-macos-15 37.64% <ø> (ø)
Homebrew-macos-26 37.96% <ø> (-0.01%) ⬇️
Homebrew-ubuntu-24.04 25.08% <0.00%> (-0.15%) ⬇️
Linux-AppImage-aarch64 26.35% <0.00%> (+26.35%) ⬆️
Linux-AppImage-x86_64 26.56% <0.00%> (-0.15%) ⬇️
PowerShell 100.00% <ø> (ø)
Web-UI 95.45% <ø> (ø)
Windows-AMD64 30.75% <ø> (ø)
Windows-ARM64 25.81% <ø> (+0.01%) ⬆️
macOS-arm64 31.25% <ø> (ø)
macOS-x86_64 31.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/wayland.h 11.11% <ø> (ø)
src/platform/linux/wlgrab.cpp 2.68% <0.00%> (-0.16%) ⬇️
src/platform/linux/wayland.cpp 18.59% <0.00%> (-1.47%) ⬇️
src/platform/linux/vulkan_encode.cpp 0.29% <0.00%> (-0.03%) ⬇️

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8926d...a310931. Read the comment docs.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Last Updated 2026-09-16 19:46:37 UTC
Source Run CI Run #5601
Commit a3109314b631c8940809498abcd524ee2d0131b9

Screenshot Comparison

PR #5734 screenshots vs screenshots baseline.

Matrix: AppImage-aarch64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: AppImage-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher ReenigneArcher added this to the vulkan milestone Sep 17, 2026
Intersect Vulkan driver modifiers with compositor modifiers before
creating GBM buffers to ensure compatible buffer formats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Vulkan encoding for wlroots capture method.

2 participants