Skip to content

Ability to search users - #1136

Merged
Toastbrot236 merged 25 commits into
LittleBigRefresh:mainfrom
Toastbrot236:user-search-normal
Sep 30, 2026
Merged

Toastbrot236 merged 25 commits into
LittleBigRefresh:mainfrom
Toastbrot236:user-search-normal

Conversation

@Toastbrot236

Copy link
Copy Markdown
Contributor

This PR does the following:

  • Makes the level search category also include matching users in its responses for games
  • Adds a separate user search category for APIv3
  • Makes level search no longer include levels by users with matching name (since searching users themselves is possible now)
  • Allows level category game responses to include users

Needs unit tests and real tests, otherwise I think it's done.

Closes #997.

@Toastbrot236 Toastbrot236 added the enhancement New feature or request label Sep 25, 2026
@Toastbrot236

Copy link
Copy Markdown
Contributor Author

Tested outside of unit tests now, works.

@Toastbrot236

Copy link
Copy Markdown
Contributor Author

Aside from adding unit tests, I also adjusted pagination for the slots endpoint (incase a listing will have way more users than levels, to allow the client to still paginate the users), and the playlist hack kept getting in the way, so I finally moved it to ByUserCategory instead.

Also, does hint_start really have to be above 0, even if there are no more pages? Since there is a test covering that.

@Toastbrot236

Copy link
Copy Markdown
Contributor Author

I just tested LBP1, 2 and 3, they don't seem to have any issues with the new behaviour (levels are paginated fine), and it seems like LBP1 ignores hint_start for all playlist requests so it doesn't break anything there either.

@Toastbrot236
Toastbrot236 merged commit 1684688 into LittleBigRefresh:main Sep 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User searching

1 participant