Repository navigation
Add configurable rate-limits for game endpoints - #1130
Merged
Merged
Conversation
Toastbrot236
changed the title
Toastbrot236
removed this from the
Get production out of partial read-only mode milestone
Contributor
Author
|
I tested most of these defaults in LBP1/2/3 a few days ago, especially the ones for fetch endpoints, and they didn't seem to trigger any rate-limits under normal operation. |
FeTetra
approved these changes
Oct 4, 2026
Toastbrot236
added a commit
that referenced
this pull request
Oct 4, 2026
The same as #1130, but for nearly all APIv3 endpoints. Shared buckets and a few comments overlap with the other PR.
Toastbrot236
added a commit
that referenced
this pull request
Oct 12, 2026
Removes all the leftover endpoint rate-limit constants outside of `EndpointBucketDefaults`, since both #1130 and #1131 are now merged. Also bumps the `EndpointRateLimitConfig` config version (even though there haven't been any stable releases between #1116 and now), just to make extra sure that all new buckets get added to the config during migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the newly introduced configurable endpoint rate-limiting system on nearly all game endpoints, making them no longer use Bunkum's rate-limit attribute and adding buckets for them to the enum and the config defaults.
This doesn't remove any of the now unused leftover hardcoded constants in
Refresh.Core.RateLimits. That should be done in a PR after this one and a similar PR for API buckets are merged.