Skip to content

fix: table2 ignores props when column definitions are not present #7713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eetwalt merged 1 commit into from
Jul 1, 2026
Merged

fix: table2 ignores props when column definitions are not present #7713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/wikis/commons/Widget/Table2/Cell.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ local function Table2Cell(props, context)
props.align,
props.nowrap,
props.shrink,
props.attributes
ColumnUtil.buildAttributes(props)
),
classes = props.classes,
children = children,
Expand Down
2 changes: 1 addition & 1 deletion lua/wikis/commons/Widget/Table2/CellHeader.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ local function Table2CellHeader(props, context)
-- Skip context lookups and property merging if there are no column definitions
if #columns == 0 then
local align = props.align
local attributes = props.attributes or {}
local attributes = ColumnUtil.buildAttributes(props)
if align == 'right' or align == 'center' then
attributes['data-align'] = align
end
Expand Down
Loading