feat(match2): Delta Force wiki-specific setup#7703
Open
Hesketh2 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Delta Force–specific Match2 support by parsing and rendering per-team ATK/DEF side indicators in match popups, and by wiring standard MatchSummary extradata (MVP, map veto) for the deltaforce wiki modules.
Changes:
- Add side-indicator rendering to
MatchSummaryusing light/dark side icons keyed off per-map extradata. - Extend deltaforce MatchGroup input parsing to provide match-level extradata (MVP, veto) and map-level side extradata.
- Adjust deltaforce copy-paste generation for map parameters (needs correction; see comments).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lua/wikis/deltaforce/MatchSummary.lua | Renders ATK/DEF indicators per team in the game row based on map extradata. |
| lua/wikis/deltaforce/MatchGroup/Input/Custom.lua | Adds wiki-specific parsing: MVP/veto match extradata and ATK/DEF side map extradata; modifies bestof behavior. |
| lua/wikis/deltaforce/GetMatchGroupCopyPaste/wiki.lua | Updates generated wikitext for match/map input fields (currently applies side fields to FFA instead of standard matches). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+69
| ---@param bestofInput string|integer? | ||
| ---@return integer? | ||
| function MatchFunctions.getBestOf(bestofInput) | ||
| local bestof = tonumber(bestofInput) or tonumber(Variables.varDefault('bestof')) | ||
|
|
||
| if bestof then | ||
| Variables.varDefine('bestof', bestof) | ||
| end | ||
|
|
||
| return bestof | ||
| end |
| } | ||
| end | ||
|
|
||
| -- Parse extradata information, particularally info about halfs and operator bans |
| } or t1side == 'DEF' and { | ||
| t1side = 'DEF', | ||
| t2side = 'ATK', | ||
| } or error('Invalid side specified: "' .. map.team1side .. '"') |
Comment on lines
75
to
77
| Array.map(Array.range(1, bestof), function(mapIndex) | ||
| return INDENT .. '|map' .. mapIndex .. '={{Map|map=|date=|finished=|vod=}}' | ||
| return INDENT .. '|map' .. mapIndex .. '={{Map|map=|team1side=|team2side= |date=|finished=|vod=}}' | ||
| end), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Specific needs for Delta Force's Match2 setup is a side Indicator for Bracket variation, in that type each match contains of one team in each Attack and Defense side so an indicator to tell which side it is are needed
Aside from MVP and Veto which is standard but also needed, thats the only wiki specific thing
How did you test this change?
https://liquipedia.net/deltaforce/Delta_Force_Invitational/Warfare/2026
https://liquipedia.net/deltaforce/Module:MatchGroup/Input/Custom/dev/hjp
https://liquipedia.net/deltaforce/Module:MatchSummary/dev/hjp