feat(PrizePool): redesign table via Table2 with collapse rework#7688
feat(PrizePool): redesign table via Table2 with collapse rework#7688Eetwalt wants to merge 53 commits into
Conversation
Eetwalt
added
c: standard
c: prize_pool
stylesheets
Looking at https://liquipedia.net/dota2/index.php?title=BLAST/SLAM/7 with old and new prizepool, there seems to be not much difference
|
| end | ||
|
|
||
| return start | ||
| return tostring(self.placeStart) |
There was a problem hiding this comment.
I don't think we need tostring here
There was a problem hiding this comment.
I believe we do, as self.placeStart get gsub :ed at Placement.lua:174 and Import.lua:539 later, which will error out right? Before it got Ordinal.toOrdinal which returned a string, but now we don't use ordinals so we need to do tostring here I think
There was a problem hiding this comment.
other solution would be to use string.gsub(self:_displayPlace(), '-', '-') in line 174
(string.gsub converts it to string before the gsub, while :gsub requires a string beforehand)
There was a problem hiding this comment.
IMO tostring() is just cleaner here. Makes the function honor its contract rather than pushing string-coercion onto every consumer
Summary
Widget/TabletoWidget/Table2(header/body/footer sections, declarativerowspan/colspan)general-collapsibletoggle rendered in the footer, replacing the per-rowapplyToggleExpandmachinery; child classes now only supply open/close label textArray.groupAdjacentBy/Table.deepEquals, extracted into_opponentPrizeCells1,1-2) instead of ordinals, with colored gold/silver/bronze badges and pale row tints for top-3.prizepool-table-wrapperrowspan/colspanfrom Table2Cell/CellHeadereven without column definitionsHow did you test this change?
dev + devtools