Skip to content

feat: add Template inline player#7609

Open
hjpalpha wants to merge 5 commits into
mainfrom
TemplateInlinePlayer
Open

feat: add Template inline player#7609
hjpalpha wants to merge 5 commits into
mainfrom
TemplateInlinePlayer

Conversation

@hjpalpha

@hjpalpha hjpalpha commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

stacked on #6863 as it uses stuff changed in that PR

prereq bot runs on sc/sc2:

  • touch run to populate Category:Pages with player hiddensort on sc/sc2
  • if that category gets entries fix them
  • write a conversion wrapper for sc/sc2 to replace player/player2 with inlinePlayer calls (so we can nuke the sc/sc2 custom stuff) https://liquipedia.net/commons/Module:Player/Display/Conversion
  • bot (subst) replace Template:Player, Template:Playersp and Template:Player2 across sc/sc2 wikis

Summary

  • idea is to gradually remove usage of Module:Player, Template:Player and Template:Player2 across wikis with a new template Template:InlinePlayer.
  • rollout needs conversion bot jobs with a conversion wrapper (Module:Player/Display/Conversion, atm build for sc/sc2, might need some adjustments for other wikis) for the subst bot runs
  • [OOS] needs pos/role icon support added in the future to be able to convert wikis like LOL where the Player template supports that

How did you test this change?

untested, but function is (except for args -> props rename) identical to one of the functions on the /Starcraft module that gets removed with this PR

To-Do with merge

Delete the modules that get removed via this PR

Comment thread lua/wikis/commons/Player/Display.lua Outdated
@hjpalpha hjpalpha marked this pull request as ready for review June 9, 2026 07:39
@hjpalpha hjpalpha requested review from a team as code owners June 9, 2026 07:39
@hjpalpha hjpalpha changed the title Template inline player feat: add Template inline player Jun 14, 2026
@Rathoz

Rathoz commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What's the difference between InlinePlayer and TemplateInlinePlayer?

Base automatically changed from playerdisplay-widget to main July 1, 2026 14:18
@ElectricalBoy ElectricalBoy force-pushed the TemplateInlinePlayer branch from 013ce57 to 312660c Compare July 1, 2026 14:44
@ElectricalBoy

Copy link
Copy Markdown
Collaborator

What's the difference between InlinePlayer and TemplateInlinePlayer?

InlinePlayer takes standardPlayer as input (i.e., Lua only) while TemplateInlinePlayer is wikicode compatible as it expects raw player args as parsed by Opponent.readSinglePlayerArgs

@hjpalpha

hjpalpha commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

yeah as eboy already stated InlinePlayer is basically the wiki code entrypoint
goal is to kick some customs and be able to remove usage of Module:Player and its templates and move player displays from wiki code to a standardized component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants