feat: rewrite AutomaticPointsTable#6941
Conversation
faa7c37 to
3fbf2f9
Compare
hjpalpha
left a comment
There was a problem hiding this comment.
seems cleaner, but still useless/unusable for lots of wikis
¯_(ツ)_/¯
8b74d5a to
022d5a6
Compare
|
i personally still hate this module and it doesn't support lots of features that are used on some wikis for points tables while having assumptions that are plain wrong for some wikis personally i think longterm we should come up with a clean version of this that supports al necessary features |
no longer true with 4d34ccb
tend to agree |
There was a problem hiding this comment.
Pull request overview
This PR modernizes Module:AutomaticPointsTable by replacing the legacy HTML-builder display modules with a widget-based implementation, and updates the SCSS to match the new structure and current styling variables.
Changes:
- Replaces
AutomaticPointsTable/Displayand/MinifiedDisplaywith a newWidget/AutomaticPointsTablerenderer. - Reworks the core module to parse opponents/tournaments and query placements/points via LPDB, then feeds the widget.
- Refactors
AutomaticPointsTable.scssinto nested selectors and updates header background styling to use CSS variables.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/AutomaticPointsTable.scss | Refactors styling structure; adds dynamic width calculation and updates header background handling. |
| lua/wikis/commons/Widget/AutomaticPointsTable.lua | New widget-based table renderer (header + rows + deductions/qualified handling). |
| lua/wikis/commons/AutomaticPointsTable/MinifiedDisplay.lua | Removes legacy minified display implementation. |
| lua/wikis/commons/AutomaticPointsTable/Display.lua | Removes legacy main display implementation. |
| lua/wikis/commons/AutomaticPointsTable.lua | Rewrites input parsing/querying/sorting and switches output to the new widget. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copied from #7167
3aad486 to
f8f88f0
Compare

Summary
Module:AutomaticPointsTableis an unused "legacy" component that has been left abandoned for years, while the "live" version used on wikis is a worse spaghetti that is not even on this repository. This PR rewrites the module with the current standards.How did you test this change?
https://liquipedia.net/valorant/User:ElectricalBoy/Sandbox3