Skip to content

feat: rewrite AutomaticPointsTable#6941

Open
ElectricalBoy wants to merge 43 commits into
mainfrom
automatic-points-table-cleanup
Open

feat: rewrite AutomaticPointsTable#6941
ElectricalBoy wants to merge 43 commits into
mainfrom
automatic-points-table-cleanup

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

Module:AutomaticPointsTable is an unused "legacy" component that has been left abandoned for years, while the "live" version used on wikis is a worse spaghetti that is not even on this repository. This PR rewrites the module with the current standards.

How did you test this change?

https://liquipedia.net/valorant/User:ElectricalBoy/Sandbox3

@ElectricalBoy ElectricalBoy added the stylesheets Changes to stylesheets label Dec 29, 2025
@ElectricalBoy ElectricalBoy force-pushed the automatic-points-table-cleanup branch from faa7c37 to 3fbf2f9 Compare December 30, 2025 01:32
@ElectricalBoy ElectricalBoy marked this pull request as ready for review December 30, 2025 06:37

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed through it on phone
can give a proper review in the next days

fwiw to me it seems it is still incompatible with the stuff craft wikis (plus several other wikis) use

Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua
Comment thread lua/wikis/commons/Widget/AutomaticPointsTable.lua Outdated

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems cleaner, but still useless/unusable for lots of wikis
¯_(ツ)_/¯

Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
@ElectricalBoy ElectricalBoy marked this pull request as draft February 5, 2026 06:58
@ElectricalBoy ElectricalBoy removed the request for review from Eetwalt February 27, 2026 02:35
@SobakaPirat

Copy link
Copy Markdown
Contributor

Would you mind adding color placement?
It gives some additional visual information

изображение

@ElectricalBoy ElectricalBoy force-pushed the automatic-points-table-cleanup branch from 8b74d5a to 022d5a6 Compare June 23, 2026 02:08
@ElectricalBoy ElectricalBoy marked this pull request as ready for review June 23, 2026 03:29
@ElectricalBoy ElectricalBoy requested review from a team as code owners June 23, 2026 03:29
@hjpalpha

Copy link
Copy Markdown
Collaborator

i personally still hate this module
it seems quite bad to only support team opponents
and the display is still bad imo

and it doesn't support lots of features that are used on some wikis for points tables while having assumptions that are plain wrong for some wikis

personally i think longterm we should come up with a clean version of this that supports al necessary features

@ElectricalBoy

Copy link
Copy Markdown
Collaborator Author

it seems quite bad to only support team opponents

no longer true with 4d34ccb

and the display is still bad imo

tend to agree

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes Module:AutomaticPointsTable by replacing the legacy HTML-builder display modules with a widget-based implementation, and updates the SCSS to match the new structure and current styling variables.

Changes:

  • Replaces AutomaticPointsTable/Display and /MinifiedDisplay with a new Widget/AutomaticPointsTable renderer.
  • Reworks the core module to parse opponents/tournaments and query placements/points via LPDB, then feeds the widget.
  • Refactors AutomaticPointsTable.scss into nested selectors and updates header background styling to use CSS variables.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
stylesheets/commons/AutomaticPointsTable.scss Refactors styling structure; adds dynamic width calculation and updates header background handling.
lua/wikis/commons/Widget/AutomaticPointsTable.lua New widget-based table renderer (header + rows + deductions/qualified handling).
lua/wikis/commons/AutomaticPointsTable/MinifiedDisplay.lua Removes legacy minified display implementation.
lua/wikis/commons/AutomaticPointsTable/Display.lua Removes legacy main display implementation.
lua/wikis/commons/AutomaticPointsTable.lua Rewrites input parsing/querying/sorting and switches output to the new widget.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread stylesheets/commons/AutomaticPointsTable.scss
Comment thread stylesheets/commons/AutomaticPointsTable.scss Outdated
Comment thread lua/wikis/commons/Widget/AutomaticPointsTable.lua
Comment thread lua/wikis/commons/Widget/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
Comment thread lua/wikis/commons/AutomaticPointsTable.lua Outdated
@ElectricalBoy ElectricalBoy force-pushed the automatic-points-table-cleanup branch from 3aad486 to f8f88f0 Compare July 2, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants